Aight - A set of triggers that ain't working

[TechGeek001]

OK, here's what I've got. What the first is supposed to do is when a player researches Recruit Riflemen, it adds them to a player group, which then applies the second trigger to them, which actually spawns the unit.

SetRifleman
Events
Unit - A unit Finishes research
Conditions
(Researched tech-type) Equal to Recruit Rifleman
Actions
Player Group - Add (Triggering player) to (All players matching ((Researched tech-type) Equal to Recruit Rifleman ))

Rifleman
Events
Time - Every 2.00 seconds of game time
Conditions
Actions
Player Group - Pick every player in (All players matching ((Researched tech-type) Equal to Recruit Rifleman )) and do (Unit - Create 1 Rifleman for (Matching player) at ((Matching player) start location) facing Default building facing degrees)

[Darkgarden]

Shouldent the player group be under actions (im not sure but it sounds it should be there (no clue but hey may want to try it)

[tru_power22]

Player Group - Add (Triggering player) to (All players matching ((Researched tech-type) Equal to Recruit Rifleman ))
Should be
Player Group - Add ((Owner Of (Triggering Unit)) to (A_Variable)

For two reasons, this would work (i think) and you can avoid memory leaks.

Player Group - Pick every player in (All players matching ((Researched tech-type) Equal to Recruit Rifleman )) and do (Unit - Create 1 Rifleman for (Matching player) at ((Matching player) start location) facing Default building facing degrees)

Should be
Player Group - Pick every player in (A_Variable) Equal to Recruit Rifleman )) and do (Unit - Create 1 Rifleman for (Matching player) at ((Matching player) start location) facing Default building facing degrees)

Of course...

[Aero]

Make a player group variable. In my example, I will use "PlayerGroup" as my player group. Also note that I'm not using real GUI...just explaining what should happen.

SetRifleman
Events
Unit - A unit Finishes research
Conditions
(Researched tech-type) Equal to Recruit Rifleman
Actions
Player Group - Add Owner of TriggeringUnit to PlayerGroup

Rifleman
Events
Time - Every 2.00 seconds of game time
Conditions
Actions
Player Group - Pick every player in PlayerGroup and do Create one Rifleman for Picked Player at Picked Player's start location facing default building facing degrees

This only leaks a point (Picked Player's start location) unless the gui behind it returns a location stored in an array or something.
I would assume a leak though.

[TechGeek001]

what's this "memory leak"?

BTW, it worked perfectly Aero thx so much

[Aero]

In terms of wc3, it's allocated memory that can no longer be accessed by WC3 to recycle. This causes a deficit of memory. With enough leaks, this will result in laggy gameplay.