Avoid Memories leak

[initialD]

I have tried making this -tele command a few times but I failed. I think I missed something on my script. Could anyone just show me how to make a -tele (set patrol to teleport) command in JASS, please?

[Xantan]

event: unit issues an order

condition: order equal to patrol

action: move unit instantly to target point of issued order

[Aero]

That leaks a location Xantan... X.X

[Xantan]

it still gives correct functions and if anyone really cares, they can fix it...

lol

[Aero]

I know..but seeing GUI leaks in the JASS section makes my cringe.

[Xantan]

I'm sorry you feel that way, feel free to tell us how to fix it, asap!

otherwise we got a crisis on our hands.

[initialD]

Thanks xantan. I made it.
About the leaks.I have no idea what it is. Could Aero explain a bit?
Here is the function I made, if that does matter.

Code: Select all

function Tp takes nothing returns nothing
local unit u=GetTriggerUnit()
local location k=GetOrderPointLoc()
if GetIssuedOrderId()==851990then
call SetUnitPosition(u,GetLocationX(k),GetLocationY(k))
endif
set u=null
set k=null
endfunction

[Aero]

That still leaks a location and can be done cleaner.

Attach a condition to your trigger first of all.

Code: Select all

function SomeCond takes nothing returns boolean
return GetIssuedOrderId()==851990
endfunction

And actions should look like this:

Code: Select all

function Tp takes nothing returns nothing
local unit u=GetTriggerUnit()
local location l=GetOrderPointLoc()
call SetUnitX(u,GetLocationX(l))
call SetUnitY(u,GetLocationY(l))
call RemoveLocation(l)
set u=null
set l=null
endfunction

SetUnitX / SetUnitY is faster than SetUnitPosition as SetUnitPosition checks pathing, map bounds ect.
SetUnitX/Y completely ignores pathing, map bounds and other limitations.

It's imperative you have "RemoveLocation(l)" to clean that location from memory. Otherwise, this floating location doesn't get removed and leeches RAM.

[initialD]

Thanks Aero. Moderator please don't delete this thread first. I will need some time to learn all that JASS. thanks.

[Bartimaeus]

Thanks Aero. Moderator please don't delete this thread first. I will need some time to learn all that JASS. thanks.

If you or someone can learn from this topic, it's not going to be deleted. (and you can learn something from this topic, so...)