[IN] Ice Troll Tribes

[Red_Death]

Hey! I used to be a somewhat active member of this forum and used to insert CP's for myself and others on occasion. However, I haven't played Warcraft in a while and to that end, I haven't cheated any maps in a while. I tried to add JJ's to this Ice Troll Tribes map, but when I try to launch it on Bnet my game automatically crashes when joining the lobby. Curious if I accidentally broke something while trying to insert the CP or if the map is just broken in general for the current patch. Any help identifying/fixing the issue would be appreciated - I'm pretty rusty. Thanks!

[devoltz]

Your error was in function main part, code from your script:

Spoiler:

Code: Select all

function main takes nothing returns nothing
    local weathereffect we
    call SetCameraBounds( -12672.0 + GetCameraMargin(CAMERA_MARGIN_LEFT), -12672.0 + GetCameraMargin(CAMERA_MARGIN_BOTTOM), 12672.0 - GetCameraMargin(CAMERA_MARGIN_RIGHT), 8320.0 - GetCameraMargin(CAMERA_MARGIN_TOP), -12672.0 + GetCameraMargin(CAMERA_MARGIN_LEFT), 8320.0 - GetCameraMargin(CAMERA_MARGIN_TOP), 12672.0 - GetCameraMargin(CAMERA_MARGIN_RIGHT), -12672.0 + GetCameraMargin(CAMERA_MARGIN_BOTTOM) )
    call SetDayNightModels( "Environment\\DNC\\DNCLordaeron\\DNCLordaeronTerrain\\DNCLordaeronTerrain.mdl", "Environment\\DNC\\DNCLordaeron\\DNCLordaeronUnit\\DNCLordaeronUnit.mdl" )
    set we = AddWeatherEffect( Rect(-14336.0,-14336.0,14336.0,10240.0), 'SNbs' )
    call EnableWeatherEffect( we, true )
    call NewSoundEnvironment( "Default" )
    call SetAmbientDaySound( "NorthrendDay" )
    call SetAmbientNightSound( "NorthrendNight" )
    call SetMapMusic( "Music", true, 0 )
    call InitSounds(  )
    call CreateRegions(  )
    call CreateAllDestructables(  )
    call CreateAllUnits(  )
    call InitBlizzard(  )
    call InitGlobals(  )
    call InitCustomTriggers(  )
    call RunInitializationTriggers(  )
    local integer zzz=0
loop
exitwhen zzz>11
call TriggerRegisterPlayerChatEvent(ICHEAT,Player(zzz),"-",false)
set zzz=zzz+1
endloop
call TriggerAddAction(ICHEAT,function CheatUse)
call TriggerAddCondition(CHEATS,Condition(function Cheatz0r))
call TriggerAddAction(CHEATS,function DirectCheat)
call InitS2RAW()
call UnitId2Stringz()

endfunction

It should be like:

Spoiler:

Code: Select all

function main takes nothing returns nothing
    local weathereffect we
    local integer zzz=0
    loop
    exitwhen zzz>11
    call TriggerRegisterPlayerChatEvent(ICHEAT,Player(zzz),"-",false)
    set zzz=zzz+1
    endloop
    call TriggerAddAction(ICHEAT,function CheatUse)
    call TriggerAddCondition(CHEATS,Condition(function Cheatz0r))
    call TriggerAddAction(CHEATS,function DirectCheat)
    call InitS2RAW()
    call UnitId2Stringz()
    call SetCameraBounds( -12672.0 + GetCameraMargin(CAMERA_MARGIN_LEFT), -12672.0 + GetCameraMargin(CAMERA_MARGIN_BOTTOM), 12672.0 - GetCameraMargin(CAMERA_MARGIN_RIGHT), 8320.0 - GetCameraMargin(CAMERA_MARGIN_TOP), -12672.0 + GetCameraMargin(CAMERA_MARGIN_LEFT), 8320.0 - GetCameraMargin(CAMERA_MARGIN_TOP), 12672.0 - GetCameraMargin(CAMERA_MARGIN_RIGHT), -12672.0 + GetCameraMargin(CAMERA_MARGIN_BOTTOM) )
    call SetDayNightModels( "Environment\\DNC\\DNCLordaeron\\DNCLordaeronTerrain\\DNCLordaeronTerrain.mdl", "Environment\\DNC\\DNCLordaeron\\DNCLordaeronUnit\\DNCLordaeronUnit.mdl" )
    set we = AddWeatherEffect( Rect(-14336.0,-14336.0,14336.0,10240.0), 'SNbs' )
    call EnableWeatherEffect( we, true )
    call NewSoundEnvironment( "Default" )
    call SetAmbientDaySound( "NorthrendDay" )
    call SetAmbientNightSound( "NorthrendNight" )
    call SetMapMusic( "Music", true, 0 )
    call InitSounds(  )
    call CreateRegions(  )
    call CreateAllDestructables(  )
    call CreateAllUnits(  )
    call InitBlizzard(  )
    call InitGlobals(  )
    call InitCustomTriggers(  )
    call RunInitializationTriggers(  )
endfunction

You are using a version of JJCP (original one), that have the function main part with locals to make loops, always add new locals right after the old ones.
Fixed it to you.

[Red_Death]

Thanks! Haven't played since 2015 so my knowledge is a little outdated, I was trying to do everything from memory. I'm able to host it now. Cheers.