Some Jass problems

[JJ2197]

What I am trying to do is make it display a message when a player trains a unit, and I want it to display a differnt message for if player 1 where to build it or player 2 etc...

Heres what I've got...

globals

Code: Select all

trigger trig

Functions

Code: Select all

function utp1 takes nothing returns boolean
return ( GetOwningPlayer(GetTrainedUnit()) == Player(0) )
endfunction
function utp2 takes nothing returns boolean
return ( GetOwningPlayer(GetTrainedUnit()) == Player(1) )
endfunction
function isut takes nothing returns boolean
if ( not ( GetUnitTypeId(GetTrainedUnit()) == 'h00A' ) ) then
return false
endif
return true
endfunction
function wptu takes nothing returns nothing
if (utp1())then
call DisplayTextToForce( GetPlayersAll(), "Player 1" )
call DisableTrigger( GetTriggeringTrigger() )
endif
if (utp2())then
call DisplayTextToForce( GetPlayersAll(), "Player 2" )
call DisableTrigger( GetTriggeringTrigger() )
endif
endfunction
function hptu takes nothing returns nothing 
set trig = CreateTrigger( )
call TriggerRegisterPlayerUnitEvent(trig,GetTriggerPlayer(),EVENT_PLAYER_UNIT_TRAIN_FINISH,Condition( function isut ))
call TriggerAddAction(trig,function wptu)                                  
endfunction

Function main

Code: Select all

call hptu()

What am I doing wrong?

[trb92]

Code: Select all

call TriggerRegisterPlayerUnitEvent(trig,GetTriggerPlayer(),EVENT_PLAYER_UNIT_TRAIN_FINISH,Condition( function isut ))

Won't work, there isn't a triggering player at that part, you need to actually specify player(0), player (1), etc.
Easiest way is:

Code: Select all

function hptu takes nothing returns nothing
local integer i  = 0 
set trig = CreateTrigger( )
loop
exitwhen i>11
call TriggerRegisterPlayerUnitEvent(trig, Player(i),EVENT_PLAYER_UNIT_TRAIN_FINISH,Condition( function isut ))
set i = i + 1
endloop
call TriggerAddAction(trig,function wptu)                                  
endfunction

[JJ2197]

Okay... now how would I change condition wptu?

[Xantan]

To triggering player

[GhettoChild]

That JASS is coded worse than Enron's mainframe or something lol. I'll help you improve it once I'm done playing here.

[weirdone2]

So let me get this you want to make a msg appear when some1 trains a unit?

[HINDYhat]

Code: Select all

function isut takes nothing returns boolean
    return GetUnitTypeId(GetTrainedUnit()) == 'h00A'
endfunction
function wptu takes nothing returns nothing
    local integer i=0
    loop
        exitwhen i>11
        call DisplayTextToPlayer(Player(i),0,0,"Player "+I2S(GetPlayerId(GetOwningPlayer(GetTrainedUnit()))+1))
        set i=i+1
    endloop
    call DisableTrigger( GetTriggeringTrigger() )
endfunction
function hptu takes nothing returns nothing
    local integer i=0
    set trig = CreateTrigger( )
    loop
        exitwhen i>11
        call TriggerRegisterPlayerUnitEvent(trig,Player(0),EVENT_PLAYER_UNIT_TRAIN_FINISH,Condition( function isut ))
        set i=i+1
    endloop
    call TriggerAddAction(trig,function wptu)
endfunction

That should work.

Please indent your script next time

[JJ2197]

Sorry... I just hate indents >.<
they annoy me...

[HINDYhat]

Auto-indent with JassCraft.

[JJ2197]

Anyways it looks like what you did is backwards... like you got it only set for it to look if only player 1 has done it rather anyone...

Also it didn't seem to work... I have trigger trig = null in the globals.... that's supposed to be like that right?