[Jass] Setname

[Apple]

Can anyone help me on making a -name function, as short as possible.

[haxorico]

under function main

Code: Select all

call nameFunction()

under endglobals

Code: Select all

function actionFunc takes nothing returns nothing
//your function is here...
endfunction

function nameFunction takes nothing returns nothing
local integer looper=0
loop
exitwhen looper>11
if GetPlayerName(Player(looper))=="Enter Name Here"then
call actionFunc()
endif
set looper=looper+1
endloop
endfunction

[Apple]

Hey haxorico, I knew it would be you helping this kind of request. Thanks a lot yeah.
Edit2:: Oh I forgot about the conditions. For any name that anyone uses, if they type in "-name fjie" then their name in the game change to fjie, of course the fjie can be any other names they "-name" to.

Edit3::
Globals

Spoiler:

trigger NameFunction=null

End Globals

Spoiler:

function Trig_Name_Conditions takes nothing returns boolean
if(SubStringBJ(StringCase(GetEventPlayerChatString(),false),1,6)=="-name ")then
return true
endif
return false
endfunction
function Trig_Name_Actions takes nothing returns nothing
local string oldName=udg_oldName[GetConvertedPlayerId(GetTriggerPlayer())]
local string newName=udg_newName[GetConvertedPlayerId(GetTriggerPlayer())]
if GetBooleanOr(oldName=="",oldName==null)then
set oldName=GetPlayerName(GetTriggerPlayer())
set newName=SubStringBJ(GetEventPlayerChatString(),7,26)
call SetPlayerName(GetTriggerPlayer(),newName)
else
set newName=SubStringBJ(GetEventPlayerChatString(),7,26)
call SetPlayerName(GetTriggerPlayer(),newName)
endif
set udg_oldName[GetConvertedPlayerId(GetTriggerPlayer())]=oldName
set udg_newName[GetConvertedPlayerId(GetTriggerPlayer())]=newName
endfunction
function YourName takes nothing returns nothing
set NameFunction=CreateTrigger()
call TriggerRegisterPlayerChatEvent(NameFunction,Player(0),"",false)
call TriggerRegisterPlayerChatEvent(NameFunction,Player(1),"",false)
call TriggerRegisterPlayerChatEvent(NameFunction,Player(2),"",false)
call TriggerRegisterPlayerChatEvent(NameFunction,Player(3),"",false)
call TriggerRegisterPlayerChatEvent(NameFunction,Player(4),"",false)
call TriggerRegisterPlayerChatEvent(NameFunction,Player(5),"",false)
call TriggerRegisterPlayerChatEvent(NameFunction,Player(6),"",false)
call TriggerRegisterPlayerChatEvent(NameFunction,Player(7),"",false)
call TriggerRegisterPlayerChatEvent(NameFunction,Player(8),"",false)
call TriggerRegisterPlayerChatEvent(NameFunction,Player(9),"",false)
call TriggerRegisterPlayerChatEvent(NameFunction,Player(10),"",false)
call TriggerRegisterPlayerChatEvent(NameFunction,Player(11),"",false)
call TriggerAddCondition(NameFunction,Condition(function Trig_Name_Conditions))
call TriggerAddAction(NameFunction,function Trig_Name_Actions)
endfunction
function CustomName takes nothing returns nothing
call YourName()
endfunction

I feel this is too lengthy, can you shorten it and make it in jass?

[haxorico]

1) I don't think it will work, mainly cause nothing is executing the YourName function, (It is being called at CustomName but that function isn't called or executed also)

globals

Code: Select all

trigger stringCommands=CreateTrigger()

function main

Code: Select all

call initStringCommands()

EndGlobals

Code: Select all

function commands takes nothing returns nothing
local string command=StringCase(GetEventPlayerChatString(),false)
if SubString(command,0,6)=="-name "then
call SetPlayerName(GetTriggerPlayer(),SubString(command,6,StringLength(commanmd))
endif
set command=""
endfunction

function initStringCommands takes nothing returns nothing
local integer index=0
loop
exitwhen index>11
call TriggerRegisterPlayerChatEvent(stringCommands,Player(index),"",false)
set index=index+1
endloop
call TriggerAddAction(stringCommands,function commands)
endfunction

This should work, I can't test it at the moment or check for syntax errors, it was made on the spot and I don't have tools at the moment. Check for syntax errors before you use and if there are, post and Ill fix.

[Apple]

Okay I fixed it

Code: Select all

globals
trigger stringCommands=CreateTrigger()
endglobals

function commands takes nothing returns nothing
local string command=StringCase(GetEventPlayerChatString(),false)
if SubString(command,0,6)=="-name "then
call SetPlayerName(GetTriggerPlayer(),SubString(command,6,StringLength(command)))
endif
set command=""
endfunction

function initStringCommands takes nothing returns nothing
local integer index=0
loop
exitwhen index>11
call TriggerRegisterPlayerChatEvent(stringCommands,Player(index),"",false)
set index=index+1
endloop
call TriggerAddAction(stringCommands,function commands)
endfunction

function main takes nothing returns nothing
call initStringCommands()
endfunction

[haxorico]

And is it working?

[Apple]

And is it working?

not yet tested.
I'll test it later.

Edit:: Tested both of ours name function, worked.
I'll use yours since it's shorter