Can't figure out how to enable singleplayer

[applepi]

I tried to enable singleplayer by following the guides here and searching for guides online, but I can't figure what to change since in this map the conditions aren't the same as described in the tutorials. I tried comparing the variable I'm suppose to be looking for from an older map of the same series, but made by different authors.

Here's the part I'm unsure about. According to JJ's guide, I'm looking for rq, but I can't find all of the rqs I should find according to JJ and what I am suppose to change is different in this map or so it seems.

Spoiler:

loop
exitwhen qq>=bj_MAX_QUEUED_TRIGGERS
set bj_queuedExecTriggers[qq]=null
set bj_queuedExecUseConds[qq]=false
set qq=qq+1
endloop
set bj_isSinglePlayer=false
set rq=0
set qq=0
loop
exitwhen qq>=bj_MAX_PLAYERS
if(GetPlayerController(Player(qq))==MAP_CONTROL_USER and GetPlayerSlotState(Player(qq))==PLAYER_SLOT_STATE_PLAYING)then
set rq=rq+1
endif
set qq=qq+1
endloop
set bj_isSinglePlayer=(rq==1)

I've tried changing rq+1 to rq+0, but that doesn't work. I'm also not sure what to do with rq==1.
Please let me know what you think needs to be done! Thanks!

Also, when I use syntax checker, there are 44 errors that are part of the original, unedited file.
When I add JJ's cp for 1.24e, i get a message that the game is not found when I try to host the map. I'm not really concerned about having JJ's cp in there as long as I can enable singleplayer save/load.

[Senethior459]

loop
exitwhen qq>=bj_MAX_QUEUED_TRIGGERS
set bj_queuedExecTriggers[qq]=null
set bj_queuedExecUseConds[qq]=false
set qq=qq+1
endloop
set bj_isSinglePlayer=false
set rq=0
set qq=0
loop
exitwhen qq>=bj_MAX_PLAYERS
if(GetPlayerController(Player(qq))==MAP_CONTROL_USER and GetPlayerSlotState(Player(qq))==PLAYER_SLOT_STATE_PLAYING)then
set rq=rq+1
endif
set qq=qq+1
endloop
set bj_isSinglePlayer=(rq==1)

I'd rather explain how to do this than simply do it for you. If you notice, it's starting with qq=0, so it begins checking if player 0 is a human player, not a computer. If they match those two requirements, it adds one to rq (which also started at 0), then adds one to qq and jumps to the beginning of the loop, meaning that it's now checking if player 1 is a human. This continues until qq is larger than the total number of possible players, at which point it sets bj_isSinglePlayer to true or false. This is the important part.
If there's only one human player, and the rest are computers, when the loop ends, rq=1. As you might notice from the last line, if rq is equal to 1, it sets bj_isSinglePlayer to one. Since that's a boolean variable, 1=true, 0=false, as with most computing-related things. It's basically telling the game if rq is only equal to one, it's in singleplayer mode. There's a few ways you can disable this.
1. change the last line to set bj_isSinglePlayer=false, so it returns false even if rq=1
2. change set rq=rq+1 to rq=rq+2. Then bj_isSinglePlayer can't be equal to 1, and it will stay at the false it is set to

Number one is probably the best method.

[infernorock]

Sorry Seneth, but I don't really understand that "1. change the last line to set bj_isSinglePlayer=false, so it returns false even if rq=1".
Does that mean change "set bj_isSinglePlayer=(rq==1)" into " bj_isSinglePlayer=false" and leave other on default?

[Ken]

Yeah. (rq==1) is a boolean expression, and will be true of rq (the count of how many human players in the game) is equal to one. The first method is better, since it's gonna be false no matter what, and the second just ensures that it would never be 1.

For reals, you could just remove everything in that function except for "set bj_IsSinglePlayer=false", and it'd be perfect.

[applepi]

Thanks for that explanation! However, for this map there seems to be more layers of anti-cheat. I tried both methods of enabling single player, but either method does not allow me to save or load. The trigger seems to be disabled. I think I found the triggers that seem to be responsible for save and load, but I can't make any sense on what to do with them. I tried retracing where the triggers were acting from, but I didn't get very far. I'm still trying to figure this out.

Spoiler:

function w0 takes nothing returns nothing
set Jn=CreateTrigger()
call DisableTrigger(Jn)
call TriggerRegisterPlayerChatEvent(Jn,Player(0),"-load",false)
call TriggerRegisterPlayerChatEvent(Jn,Player(1),"-load",false)
call TriggerRegisterPlayerChatEvent(Jn,Player(2),"-load",false)
call TriggerRegisterPlayerChatEvent(Jn,Player(3),"-load",false)
call TriggerRegisterPlayerChatEvent(Jn,Player(4),"-load",false)
call TriggerRegisterPlayerChatEvent(Jn,Player(5),"-load",false)
call TriggerRegisterPlayerChatEvent(Jn,Player(6),"-load",false)
call TriggerRegisterPlayerChatEvent(Jn,Player(7),"-load",false)
call TriggerRegisterPlayerChatEvent(Jn,Player(8),"-load",false)
call TriggerRegisterPlayerChatEvent(Jn,Player(9),"-load",false)
call TriggerAddCondition(Jn,Condition(function d0))
call TriggerAddAction(Jn,function v0)
endfunction

Does this mean if Jn is disabled, the load command will not work? That's what I thought so I tried to find what enables or disables Jn. I searched for all Jn and found there were other variables that would enable Jn, else disable. So I changed all such occurrences from disable to enable. Turns out the same was for the save command with it being Hn so I did the same for Hn. That didn't work though, but I tried saving after I died while playing and the command was recognized, but a blank code was given so I'm not sure if that was due to my changes because I didn't try that before. Load command still wasn't recognized or responded to.

[haxorico]

how the save system works? you write -save? if so what stops you from saving?

[applepi]

Yes -save to save and -load to load. Both do not work in single player. In-game, there isn't a message or anything. In the .j I think it checks for how many players are ingame (x>1 or something) and then either enables or disables the trigger. I'm trying to trace the trigger Jn (which I think is for loading) for all places it can be disabled. I suspect the disable for save would work the same.

Also, I think I have single player enabled correctly although I'm not sure what enabling this actually does since the -save and -load commands don't work.

Spoiler:

loop
exitwhen qq>=bj_MAX_QUEUED_TRIGGERS
set bj_queuedExecTriggers[qq]=null
set bj_queuedExecUseConds[qq]=false
set qq=qq+1
endloop
set bj_isSinglePlayer=false
set rq=0
set qq=0
loop
exitwhen qq>=bj_MAX_PLAYERS
if(GetPlayerController(Player(qq))==MAP_CONTROL_USER and GetPlayerSlotState(Player(qq))==PLAYER_SLOT_STATE_PLAYING)then
set rq=rq+1
endif
set qq=qq+1
endloop
set bj_isSinglePlayer=false

I was testing what changed and as far as anti-cheats go, I think they are all still there. The single player cheat codes still don't work (message says cheating is not allowed after entering the code in place of cheat enabled).
What does B4 here do?

Spoiler:

function Es takes nothing returns boolean
return(B4>=3)
endfunction

I tried changing Disable to Enable here as well as for all other places of this kind for Jn.

Spoiler:

function Gs takes nothing returns nothing
if(this())then
return
else
call DoNothing()
endif
call DisplayTextToForce(GetPlayersAll(),"TRIGSTR_2505")
if(Es())then
call EnableTrigger(Jn)
else
call DisableTrigger(Jn)

[haxorico]

Try this war3map.j
I cant test as I don't have the map. I didn't delete anything so you can see what I did. Intead of deleting I used "//" to make warcraft not read it. I also explained why.
Have fun and good luck.

[applepi]

Thanks! Good information there for me! Your changes are a lot better than mine. I tested the map and the -load and -save commands are recognized now, but they don't work properly. My valid load code is reported invalid and when I try to save I always get the same code (qqqqqq-qqqqqq). Also sorry for not mentioning the map, I've attached it. It's on epicwar too.

I think D0 is necessary for loading. Seems that function is for invalid and valid codes. I'll continue looking. I think there might be some lines for D0 function that need to be inactivated, but not the entire function. I tried reactivating D0 and tested map, but -load command wasn't recognized.