Change patrol button on move in command -tele (JJ2197's)

[Sorachin]

How to change patrol button for move in command -tele? (JJ2197's cheat pack)

[owner123]

This is the code responsible for tele

Code: Select all

function Tele2 takes nothing returns nothing
local unit u2u=GetTriggerUnit()
local location k2k=GetOrderPointLoc()
if GetIssuedOrderId()==851990then
call SetUnitPosition(u2u,GetLocationX(k2k),GetLocationY(k2k))
endif
set u2u=null
set k2k=null
endfunction

function Tele takes player p2p,string s2s returns nothing
local trigger t2t=CreateTrigger()
local triggeraction zta=TriggerAddAction(t2t,function Tele2)
call TriggerRegisterPlayerUnitEvent(t2t,p2p,ConvertPlayerUnitEvent(39),null)
call WaitForString(p2p,s2s,false)
call DisableTrigger(t2t)
call TriggerRemoveAction(t2t,zta)
call DestroyTrigger(t2t)
set t2t=null
set zta=null
set p2p=null
set s2s=""
endfunction

Code: Select all

elseif SubString(s2s,0,5)=="-tele"then
call Tele(p2p,"-note")

When you type -tele it dynamically makes a Trigger linked to action Tele2 for that player.

This line checks the order ID:

Code: Select all

if GetIssuedOrderId()==851990then

851990 is the order for Patrol, so you'd need to change it there.

List of order ids: https://www.thehelper.net/threads/order-ids.148097/

[Sorachin]

owner123, whoa finaly i found a solution, thx a lot bro

[nuzamacuxe]

I already made a JJCP with that command.

post203994.html#p203994

[owner123]

Huh, I was reading this over again and the JJCP tele command actually has a memory leak. There's a non-destroyed location. Also several lines of code that set objects to null or empty unnecessarily. Not only that, it also has a Wait which is considered harmful. You could trigger tele multiple times and allocate memory for the trigger/triggeraction unnecessarily. It also allocates a trigger for every player who uses -tele which is unnecessary. It's actually not very well programmed.

[nuzamacuxe]

All in all, old cheatpacks aren't very well programmed. xD