How do I add a new jass trigger to an existing .j?

[darkxion]

OK, so let's say I create a new trigger, and convert it to custom text. How can I add this trigger to an existing .j? I tried adding the trigger to a random spot in the .j, the map ran fine when I loaded it, but the trigger wouldn't work. Any help would be great, thanks.

Code: Select all

function Trig_Untitled_Trigger_001_Conditions takes nothing returns boolean
    if ( not ( GetItemOfTypeFromUnitBJ(GetTriggerUnit(), 'I00E') == GetManipulatedItem() ) ) then
        return false
    endif
    return true
endfunction

function Trig_Untitled_Trigger_001_Actions takes nothing returns nothing
    call SetItemDroppableBJ( GetManipulatedItem(), true )
    call UnitRemoveItemSwapped( GetManipulatedItem(), GetTriggerUnit() )
    call UnitAddItemByIdSwapped( 'I00E', GetTriggerUnit() )
endfunction

[Xantan]

Need to call it in function main.

Need to list it in globals.

[globals]
trigger gg_untitled_gay_gui_trigger_001 = null


[functions]
Init Trig_gg_untitled_gay_gui_trigger_001()


thats the noob way.

[darkxion]

Firstly, owch (even though I am a noob). Secondly, thanks =P

[Xantan]

lol, np. let me know if you need any help.

[darkxion]

Well actually I had either posted wrong or just forgot the last part the first time, this is actually the entire trigger.

Spoiler:

function Trg_greed_Conditions takes nothing returns boolean
if ( not ( GetItemOfTypeFromUnitBJ(GetTriggerUnit(), 'I00E') == GetManipulatedItem() ) ) then
return false
endif
return true
endfunction

function Trig_greed_Actions takes nothing returns nothing
call SetItemDroppableBJ( GetManipulatedItem(), true )
call UnitRemoveItemSwapped( GetManipulatedItem(), GetTriggerUnit() )
call UnitAddItemByIdSwapped( 'I00E', GetTriggerUnit() )
endfunction

//===========================================================================
function InitTrig_greed takes nothing returns nothing
set gg_trg_greed = CreateTrigger( )
call TriggerRegisterAnyUnitEventBJ( gg_trg_greed, EVENT_PLAYER_UNIT_USE_ITEM )
call TriggerAddCondition( gg_trg_greed, Condition( function Trig_greed_Conditions ) )
call TriggerAddAction( gg_trg_greed, function Trig_greed_Actions )
endfunction

I added

Code: Select all

trigger gg_trig_greed=null

to the globals, and added

Code: Select all

function InitTrig_greed takes nothing returns nothing
    set gg_trg_greed = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_greed, EVENT_PLAYER_UNIT_USE_ITEM )
    call TriggerAddCondition( gg_trg_greed, Condition( function Trig_greed_Conditions ) )
    call TriggerAddAction( gg_trg_greed, function Trig_greed_Actions )
endfunction

in the functions

Than added the

Code: Select all

function Trig_greed_Conditions takes nothing returns boolean
    if ( not ( GetItemOfTypeFromUnitBJ(GetTriggerUnit(), 'I00E') == GetManipulatedItem() ) ) then
        return false
    endif
    return true
endfunction

function Trig_greed_Actions takes nothing returns nothing
    call SetItemDroppableBJ( GetManipulatedItem(), true )
    call UnitRemoveItemSwapped( GetManipulatedItem(), GetTriggerUnit() )
    call UnitAddItemByIdSwapped( 'I00E', GetTriggerUnit() )
endfunction

part in, and when I saved and did a syntax check, I got 2 errors.
Line 488: Undefined function.
Line 489: Undefined function.

Line 488 being

Code: Select all

call TriggerRegisterAnyUnitEventBJ( gg_trg_greed, EVENT_PLAYER_UNIT_USE_ITEM )

Line 489 being

Code: Select all

call TriggerAddCondition( gg_trg_greed, Condition( function Trig_greed_Conditions ) )

This is probably something simple, to someone with even a little skill with JASS =S

[trb92]

Code: Select all

trigger gg_trig_greed=null

Should be

Code: Select all

trigger gg_trg_greed=null

In the globals, since gg_trg_greed is what your using later, not gg_trig_greed.

[darkxion]

Code: Select all

trigger gg_trig_greed=null

Should be

Code: Select all

trigger gg_trg_greed=null

In the globals, since gg_trg_greed is what your using later, not gg_trig_greed.

Tried that too.

I think I need to "call" something, somewhere.

[JJ2197]

Try this....

Code: Select all

function Trig_greed_Conditions takes nothing returns boolean
    if ( not ( GetItemOfTypeFromUnitBJ(GetTriggerUnit(), 'I00E') == GetManipulatedItem() ) ) then
        return false
    endif
    return true
endfunction
function Trig_greed_Actions takes nothing returns nothing
    call SetItemDroppableBJ( GetManipulatedItem(), true )
    call UnitRemoveItemSwapped( GetManipulatedItem(), GetTriggerUnit() )
    call UnitAddItemByIdSwapped( 'I00E', GetTriggerUnit() )
endfunction
function InitTrig_greed takes nothing returns nothing
    local trigger gg_trg_greed=null
    set gg_trg_greed = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_greed, EVENT_PLAYER_UNIT_USE_ITEM )
    call TriggerAddCondition( gg_trg_greed, Condition( function Trig_greed_Conditions ) )
    call TriggerAddAction( gg_trg_greed, function Trig_greed_Actions )
endfunction

[darkxion]

With that, do I need to add trigger gg_greed=null in the globals?

[JJ2197]

No, It's right in the functions as a local... though if you have the trigger in another function though (which I would imagine no) then yes you would want to put in globals...

And when you got the error I would assume you meant these were the errors...

Code: Select all

call TriggerAddCondition( gg_trg_greed, Condition( function Trig_greed_Conditions ) )
call TriggerAddAction( gg_trg_greed, function Trig_greed_Actions )